-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enabling primary ipv6 address on EC2 instance #36425
Open
arianvp
wants to merge
8
commits into
hashicorp:main
Choose a base branch
from
arianvp:enable-primary-ipv6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first ipv6 address will be marked immutable and can not be removed untill the instance is terminated
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/S
Managed by automation to categorize the size of a PR.
service/ec2
Issues and PRs that pertain to the ec2 service.
service/vpc
Issues and PRs that pertain to the vpc service.
labels
Mar 16, 2024
terraform-aws-provider
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
Mar 16, 2024
arianvp
force-pushed
the
enable-primary-ipv6
branch
from
March 17, 2024 00:00
a44ea60
to
6ba9cb9
Compare
arianvp
changed the title
Enable primary ipv6
Add support for enabling primary ipv6 address on EC2 instance
Mar 17, 2024
github-actions
bot
added
size/M
Managed by automation to categorize the size of a PR.
and removed
size/S
Managed by automation to categorize the size of a PR.
labels
Mar 17, 2024
arianvp
commented
Mar 17, 2024
Once this boolean is set to true it can not be set to false without recreating the network interface. IDK how to model it being false by default though
justinretzolk
added
enhancement
Requests to existing resources that expand the functionality or scope.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Mar 18, 2024
@justinretzolk anything we can help to land this? |
Any update on this? I really would like this to be in. Anything I can do to make this easier to merge or review? Thanks |
Now that #37142 has landed, this one needs to be rebased & adapted to that, and basically is now "do the same thing, for VPC network interfaces & ec2 instances, please"? |
Yep seems like it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Requests to existing resources that expand the functionality or scope.
service/ec2
Issues and PRs that pertain to the ec2 service.
service/vpc
Issues and PRs that pertain to the vpc service.
size/M
Managed by automation to categorize the size of a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Primary IPv6 Addresses.
When the boolean
enable_primary_ipv6
is set; the first ipv6 address of the first interface is marked as the primary address.Setting this boolean makes sure that the assigned Ipv6 address of the instance never changes. This is a prerequisite to use and instance in an IPv6 subnet with an IPv6 ELB target group (#35010 #36423 )
This option can not be undone. The address stays immutable. Though I'm not sure how to model set-once options in terraform. Feedback appreciated.
Relations
Closes #36424
References
Output from Acceptance Testing